Draft
Conversation
pi-alexander-popel
force-pushed
the
main
branch
from
30c6ef8 to
2a18893
Compare
Contributor
justadreamer
left a comment
justadreamer
left a comment
There was a problem hiding this comment.
Hi James, this can be done, however we perhaps will shoot ourselves in the foot by requiring this strictness and will also introduce a layer of bureaucracy and encourage people to give Approvals only to speed things up without proper review.
Our CI is built with a flaw that we couple testing and merging, and that is only triggered post-review. So I suggest we postpone this change a bit - until we decouple testing and merging - so that testing can be performed regardless, and merging only if a proper review was given.
pi-alexander-popel
force-pushed
the
main
branch
4 times, most recently
from
b1adbfe to
3892b97
Compare
pi-alexander-popel
force-pushed
the
main
branch
4 times, most recently
from
94bb63b to
fef7af0
Compare
pi-alexander-popel
force-pushed
the
main
branch
4 times, most recently
from
ec29698 to
6d34512
Compare
pi-alexander-popel
force-pushed
the
main
branch
13 times, most recently
from
f084af2 to
8bf4a35
Compare
pi-alexander-popel
force-pushed
the
main
branch
2 times, most recently
from
1f71641 to
309e234
Compare
pi-alexander-popel
force-pushed
the
main
branch
3 times, most recently
from
782c18c to
232c622
Compare
pi-alexander-popel
force-pushed
the
main
branch
from
c175f54 to
0c517e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.