1 implement non uniform compact finite difference schemes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This coefficient acts on f_{i+1} - coefficient A following
Gamet et al. (1999).
Atleast not as used here.
Adds test that derivative RHS obeys law of derivatives when function is shifted by a constant
Calling error stop from PURE functions is only supported in f2018.
Otherwise it fails the tests
Currently missing terms that cancel, but passing coefficient verification with optimisation
Rearranges coefficient computation to evaluate terms that should cancel together.
These should cancel for constant h
The grid stencil is symmetric (i-2 i-1 i i+1 i+2) - the delta stencil is not (i-1 i i+1 i+2) where h_k = x_k - x_k-1 (Gammet et al 1999) Added checking to coefficeints that stencil is correctly sized
…hub.com:3decomp/NuCFD into 8-tests-fail-under-floating-point-optimisations
…optimisations Fix finite difference scheme test failures under floating point optimisations
OFF by default
pbartholomew08
added this to the
Demonstrate non-uniform compact finite difference schemes milestone
pbartholomew08
removed this from the
Demonstrate non-uniform compact finite difference schemes milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.