TILES-6268 preview tiles for ios #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Farfurix
approved these changes
Jun 9, 2025
itanka9
approved these changes
Jun 16, 2025
| @@ -368,7 +388,8 @@ L.MobileTileLayer = L.TileLayer.extend({ | |||
| var needPreview = this._needPreviewTile(wrapCoords); | |||
|
|
|||
| var url = needPreview ? this._previewUrl : this._url; | |||
Contributor
There was a problem hiding this comment.
Я бы как-то вот так выразил.
var url = needPreview && !this._isAppleDevice() ? this._previewUrl : this._url;Потому как когда читаешь строчку ниже - var tile = this.createTile(wrapCoords, L.bind(showPreviewForIphone ? this._previewReady : this._tileReady, this, coords), url); можно впасть в заблуждение, подумав, что показ превью определяется исплючительно тем, айфон у тебя или нет. А это не так.
Contributor
Author
There was a problem hiding this comment.
Тут от showPreviewForIphone выбирается какой бинд выпооняется, я пока так оставил , если ты не против
| return true; | ||
| }, | ||
|
|
||
| _isAppleDevice: function() { |
Contributor
There was a problem hiding this comment.
У тебя эта проверка сейчас выполняется при добавлении каждого тайла (в методе addTile()), что избыточно. Сделай ее один раз, результат запиши во флажок и пользуйся в методе addTile() флажком.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.