TILES-7536 fix show copyright message #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalyanov
reviewed
Apr 30, 2025
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "2gis-maps", | |||
| "version": "4.0.4", | |||
| handleTileError.bind(this)(); | ||
| } | ||
| }); | ||
| }.bind(this)); |
Contributor
There was a problem hiding this comment.
- а зачем вообще создавать 2 функции, когда достаточно одной, что-то типа validateKeyResponse
- давай валидацию перенесем внутрь класса ApiKeyValidator, судя по его названию, этим должен он заниматься, но почему-то сама валидация написана тут
kalyanov
reviewed
May 1, 2025
| }, | ||
|
|
||
| validateKeyResponse: function(map) { | ||
| this.map = map; |
Contributor
There was a problem hiding this comment.
Странно же в методе валидации запоминать инстанс карты, это надо сделать еще пои инициализации.
Contributor
Author
There was a problem hiding this comment.
Да, согласен. Тут даже всю сущность смысла нет передавать достаточно только контейнера. Поправил
kalyanov
approved these changes
May 1, 2025
Contributor
kalyanov
left a comment
kalyanov
left a comment
There was a problem hiding this comment.
Добавь еще пэддинг со всех сторон у контейнера с сообщение о ключе, а то прилепает к границам
EvgenyRodygin
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.