Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates three separate Dockerfiles (node, sequencer, and prover) into a single unified Dockerfile.target that uses cargo-chef for improved dependency caching and build efficiency. The changes also update the justfile to use a GitHub Container Registry path and reference the new unified Dockerfile.
Key Changes:
- Unified Docker build strategy using multi-stage builds with cargo-chef for better caching
- Rust version upgraded from 1.88 to 1.90
- Registry path changed from "1sixtech" to "ghcr.io/1sixtech"
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| docker/Dockerfile.target | New unified Dockerfile supporting all three binaries (node, sequencer, prover) with cargo-chef for dependency caching |
| justfile | Updated docker-build and docker-run commands to use new registry path and unified Dockerfile |
| docker/Dockerfile.node | Removed - replaced by unified Dockerfile.target |
| docker/Dockerfile.sequencer | Removed - replaced by unified Dockerfile.target |
| docker/Dockerfile.prover | Removed - replaced by unified Dockerfile.target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f8f0492 to
cdc8f2d
Compare
Signed-off-by: Sacha Froment <[email protected]>
cdc8f2d to
7f5a759
Compare
Kanet1105
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
It will be way easier to handle and also it will give us shared caching and just good things overall
Description
Remove previous docker and use 1 dockerfile with better caching
Closes #issue_number
Type of change
Checklist