Skip to content

refactor: one dockerfile to rule them all#274

Merged
sfroment merged 2 commits intomainfrom
one-dockerfile
Nov 25, 2025
Merged

refactor: one dockerfile to rule them all#274
sfroment merged 2 commits intomainfrom
one-dockerfile

Conversation

@sfroment
Copy link
Contributor

Why is this change necessary?

It will be way easier to handle and also it will give us shared caching and just good things overall

Description

Remove previous docker and use 1 dockerfile with better caching

Closes #issue_number

Type of change

  • Other (please describe): Refactor Docker setup

Checklist

  • I have tested my changes
  • I have updated documentation if needed
  • I have reviewed my code for best practices

Copilot AI review requested due to automatic review settings November 21, 2025 16:09
@sfroment sfroment requested a review from Giwook-Han as a code owner November 21, 2025 16:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates three separate Dockerfiles (node, sequencer, and prover) into a single unified Dockerfile.target that uses cargo-chef for improved dependency caching and build efficiency. The changes also update the justfile to use a GitHub Container Registry path and reference the new unified Dockerfile.

Key Changes:

  • Unified Docker build strategy using multi-stage builds with cargo-chef for better caching
  • Rust version upgraded from 1.88 to 1.90
  • Registry path changed from "1sixtech" to "ghcr.io/1sixtech"

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
docker/Dockerfile.target New unified Dockerfile supporting all three binaries (node, sequencer, prover) with cargo-chef for dependency caching
justfile Updated docker-build and docker-run commands to use new registry path and unified Dockerfile
docker/Dockerfile.node Removed - replaced by unified Dockerfile.target
docker/Dockerfile.sequencer Removed - replaced by unified Dockerfile.target
docker/Dockerfile.prover Removed - replaced by unified Dockerfile.target

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sfroment sfroment merged commit d540edc into main Nov 25, 2025
7 checks passed
@sfroment sfroment deleted the one-dockerfile branch November 25, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants