Updated windows-bindgen dependency version to 0.58.0#36
Open
pasabanov wants to merge 1 commit into1Password:mainfrom
Open
Updated windows-bindgen dependency version to 0.58.0#36pasabanov wants to merge 1 commit into1Password:mainfrom
windows-bindgen dependency version to 0.58.0#36pasabanov wants to merge 1 commit into1Password:mainfrom
Conversation
Member
|
I'm not sure there's a reason to do this. The generated bindings haven't needed updated in a while and there's no changes being made here either. |
Contributor
Author
|
Isn't a version update always a good idea? |
Member
|
Not always, no. I generally try to be conservative with dep updates because fragmenting people's lockfiles is worse then using out-of-date code. In this case its not a dependency downstream users see but the generated Windows code hasn't needed updating so this is of similarly low priority/concern right now. If you want to merge this, it needs to at least handle updates to the configuration syntax for the code generator, update the checked-in bindings, etc so that these don't become a disjoint problem N months from now when it needs to be ran again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.