Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@1673beta
Copy link
Owner

What

EntityをMisskey 2025.4.0に追従

@1673beta 1673beta requested a review from Copilot April 23, 2025 16:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the entity definitions to align with Misskey 2025.4.0, including schema changes, removals, additions, and new relationship definitions.

  • Removed the is_root field from the User entity
  • Added new fields and relations for chat features and system accounts
  • Introduced several new entities including chat_room, chat_message, chat_approval, and updated associated modules

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/entities/user.rs Removed is_root, added chat_scope field, and defined new relations
src/entities/system_account.rs Added new system_account entity
src/entities/role.rs Added preserve_assignment_on_move_account field
src/entities/prelude.rs Included new chat and system account entities
src/entities/mod.rs Registered new modules corresponding to chat and system entities
src/entities/meta.rs Removed proxy_account_id field and updated relation to use root_user_id
src/entities/drive_file.rs Added relation for ChatMessage
src/entities/chat_room_membership.rs Introduced new chat_room_membership entity
src/entities/chat_room_invitation.rs Introduced new chat_room_invitation entity
src/entities/chat_room.rs Introduced new chat_room entity
src/entities/chat_message.rs Introduced new chat_message entity with relation naming concerns
src/entities/chat_approval.rs Introduced new chat_approval entity with relation naming concerns
src/entities/antenna.rs Added exclude_notes_in_sensitive_channel field
src/cli/user/delete.rs Revised deletion logic using logging instead of error returns
src/cli/note/mod.rs Added a value parser for NoteVisibility argument
src/cli/note/delete.rs Improved code formatting for reply count update
Files not reviewed (1)
  • Makefile: Language not supported
Comments suppressed due to low confidence (2)

src/entities/chat_message.rs:50

  • [nitpick] The relation name 'User2' is ambiguous. Consider renaming it to 'Recipient' to clarify its role as the recipient in a chat message.
  User2,

src/entities/chat_approval.rs:26

  • [nitpick] The relation name 'User2' is ambiguous in this context. Consider renaming it to a more descriptive name such as 'Approver' to improve readability.
  User2,

@1673beta
Copy link
Owner Author

2025.3.0以前のバージョンに対するサポートをどうしよう

@1673beta
Copy link
Owner Author

src/entities/models.rsをやめてsrc/entities/2025-3-0/models.rsとかにするか

@1673beta
Copy link
Owner Author

src/entities/models.rsをやめてsrc/entities/2025-3-0/models.rsとかにするか

これすればIceShrimp.jsとかにも使えるかも

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants