This repository was archived by the owner on Sep 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(entities): update entitiies to 2025.4.0 #55
Draft
1673beta
wants to merge
5
commits into
develop
Choose a base branch
from
update-entities-202540
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the entity definitions to align with Misskey 2025.4.0, including schema changes, removals, additions, and new relationship definitions.
- Removed the is_root field from the User entity
- Added new fields and relations for chat features and system accounts
- Introduced several new entities including chat_room, chat_message, chat_approval, and updated associated modules
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/entities/user.rs | Removed is_root, added chat_scope field, and defined new relations |
| src/entities/system_account.rs | Added new system_account entity |
| src/entities/role.rs | Added preserve_assignment_on_move_account field |
| src/entities/prelude.rs | Included new chat and system account entities |
| src/entities/mod.rs | Registered new modules corresponding to chat and system entities |
| src/entities/meta.rs | Removed proxy_account_id field and updated relation to use root_user_id |
| src/entities/drive_file.rs | Added relation for ChatMessage |
| src/entities/chat_room_membership.rs | Introduced new chat_room_membership entity |
| src/entities/chat_room_invitation.rs | Introduced new chat_room_invitation entity |
| src/entities/chat_room.rs | Introduced new chat_room entity |
| src/entities/chat_message.rs | Introduced new chat_message entity with relation naming concerns |
| src/entities/chat_approval.rs | Introduced new chat_approval entity with relation naming concerns |
| src/entities/antenna.rs | Added exclude_notes_in_sensitive_channel field |
| src/cli/user/delete.rs | Revised deletion logic using logging instead of error returns |
| src/cli/note/mod.rs | Added a value parser for NoteVisibility argument |
| src/cli/note/delete.rs | Improved code formatting for reply count update |
Files not reviewed (1)
- Makefile: Language not supported
Comments suppressed due to low confidence (2)
src/entities/chat_message.rs:50
- [nitpick] The relation name 'User2' is ambiguous. Consider renaming it to 'Recipient' to clarify its role as the recipient in a chat message.
User2,
src/entities/chat_approval.rs:26
- [nitpick] The relation name 'User2' is ambiguous in this context. Consider renaming it to a more descriptive name such as 'Approver' to improve readability.
User2,
Owner
Author
|
2025.3.0以前のバージョンに対するサポートをどうしよう |
Owner
Author
|
|
Owner
Author
これすればIceShrimp.jsとかにも使えるかも |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
EntityをMisskey 2025.4.0に追従