change: use replace_into instead of insert_into #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #113, we are running into UNIQUE CONSTRAINT conflicts on each stats_version updated. Previously, we'd fall back to upserting each height in each table separatly. This had a few problems: 1. It's slower than just deleting and inserting the stats for that height. 2. It's more code and logic to maintain. 3. And most importantly, there seems to be a memory leak when doing so. It just wasn't discovered before, as these manual upserts were rare. Using SQLite's REPLACE (i.e. INSERT OR REPLACE) is an improvement on all of the above points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #113, we are running into UNIQUE CONSTRAINT conflicts on each stats_version updated. Previously, we'd fall back to upserting each height in each table separatly. This had a few problems:
Using SQLite's REPLACE (i.e. INSERT OR REPLACE) is an improvement on all of the above points.
fixes #117