-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Update jogging panel to API v2 #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Import and extend JoggingConnection from nova.js v1
f3e9415 to
37f9671
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the codebase from nova-js v1 API to v2 API. The migration involves updating API imports, refactoring data structures, and introducing new connection classes for motion stream and jogging functionality.
- Updated
@wandelbots/nova-jsdependency to v2 pre-release version - Replaced v1 API types and imports with v2 equivalents across components
- Introduced new
MotionStreamConnectionandJoggerConnectionclasses to replace v1'sConnectedMotionGroupand jogging functionality - Migrated data structures from nested objects to array-based representations (e.g.,
Posenow uses arrays instead of{x, y, z}objects)
Reviewed Changes
Copilot reviewed 38 out of 39 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates nova-js dependency to v2 pre-release version |
| src/lib/MotionStreamConnection.ts | New class for managing motion group state streaming |
| src/lib/JoggerConnection.ts | New class for robot jogging control via websockets |
| src/lib/motionStateUpdate.ts | New utilities for comparing motion states with array-based poses |
| src/components/jogging/*.tsx | Updated to use new JoggerConnection and v2 API types |
| src/components/robots/*.tsx | Changed imports from @wandelbots/nova-api/v1 to @wandelbots/nova-js/v1 |
| stories/*.tsx | Updated imports and type definitions for v2 compatibility |
| docs/*.md | Added documentation for new connection classes |
Comments suppressed due to low confidence (1)
src/components/jogging/JoggingStore.ts:143
- This expression has no effect.
jogger.motionStream.controllerId
stefanwagnerdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would appreciate some added Unit Tests against mocks for the jogger implementation if possible.
|
Please do a design pass with the design team about the removal of the coordinate system. I think the selector could now be removed and instead a simple toggle for switching beteen tool and world introduced. |
After a brief discussion we are going for hiding the select field, but keeping the three other selects (with the Increment option spanning both columns). |
04cb938 to
33cdf67
Compare
33cdf67 to
4b7ad67
Compare
3ead760 to
798859b
Compare
evrys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jogged a bit with a virtual fanuc, seems to work!
Update the jogging functionality to use API version 2. The
JoggerConnectionthat powers the jogging panel is moved from the nova.js library to the react components.Updates nova.js to version 3.3
BREAKING CHANGE: Updated to use API v2 under the hood; selecting a different controller coordinate system for jogging is currently not possible. You can still use the tool's coordinate system by choosing the Tool option in "Orientation" dropdown.
Storybook Link