refactor: restructure repo and migrate dependencies to vcs #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vortexuser
force-pushed
the
refactor/filestructure
branch
from
b1188fe to
9e8b461
Compare
vortexuser
force-pushed
the
refactor/filestructure
branch
from
37be6da to
298459c
Compare
vortexuser
force-pushed
the
refactor/filestructure
branch
from
298459c to
b3e5f7f
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the repository from a git submodules-based dependency management system to using the ROS-standard vcs tool. The migration aims to simplify dependency management and align with common ROS practices.
Key changes:
- Migration from git submodules to vcs-based dependency management with separate SSH and HTTPS configuration files
- Addition of utility scripts for network configuration and data recording
- Comprehensive documentation update explaining the new vcs-based workflow
- CI/CD workflow improvements and pre-commit hook updates
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| submodules/zed-ros2-wrapper | Removed git submodule reference |
| submodules/isaac_ros_common | Removed git submodule reference |
| submodules/flir_camera_driver | Removed git submodule reference |
| scripts/set_MTU_nic.sh | Added network MTU configuration script |
| scripts/record_bag_perception.sh | Added ROS bag recording script for perception topics |
| perception_setup/launch/pipeline_detection.launch.py | Updated camera serial number |
| entrypoint.sh | Removed old Isaac ROS entrypoint script |
| dependencies.ssh.repos | Added vcs dependency file for SSH-based cloning |
| dependencies.repos | Removed old dependency file |
| dependencies.https.repos | Added vcs dependency file for HTTPS-based cloning |
| README.md | Comprehensive rewrite documenting vcs-based workflow |
| .pre-commit-config.yaml | Updated hook versions and added new ament linting hooks |
| .isaac_ros_common-config | Removed Isaac ROS configuration file |
| .gitmodules | Removed git submodules configuration |
| .github/workflows/semantic-release.yml | Renamed workflow job |
| .github/workflows/pre-commit.yml | Added new pre-commit CI workflow |
| .github/workflows/industrial-ci.yml | Updated workflow configuration and triggers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.