perf: break loop wihen found the first definePage #230
Conversation
|
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/core/src/page.ts (1)
138-164: Prevent crash when definePage() has no arguments; simplify with early-return and supportexport default definePage(...).Without guarding for a missing first argument,
tryPageMetaFromMacrowill callbabelGenerateonundefinedand throw. Also, you can keep the perf goal by validating immediately upon the first match and returning early. This variant also handles the commonexport default definePage(...)form.Apply:
export function findMacro(stmts: t.Statement[], filename: string): t.CallExpression | undefined { - let macro: t.CallExpression | undefined - - for (const stmt of stmts) { - let node: t.Node = stmt - if (stmt.type === 'ExpressionStatement') - node = stmt.expression - - if (isCallOf(node, 'definePage')) { - macro = node - break - } - } - - if (!macro) - return - - // 提取 macro function 内的第一个参数 - const [opt] = macro.arguments - - // 检查 macro 的参数是否正确 - if (opt && !t.isFunctionExpression(opt) && !t.isArrowFunctionExpression(opt) && !t.isObjectExpression(opt)) { - debug.definePage(`definePage() 参数仅支持函数或对象: ${filename}`) - return - } - - return macro + for (const stmt of stmts) { + let node: t.Node | undefined + if (stmt.type === 'ExpressionStatement') + node = stmt.expression + else if (stmt.type === 'ExportDefaultDeclaration') + node = stmt.declaration as t.Node + else + node = stmt + + if (isCallOf(node, 'definePage')) { + const call = node as t.CallExpression + const [opt] = call.arguments + if (!opt) { + debug.definePage(`definePage() 需要一个参数（函数或对象）: ${filename}`) + return + } + if (!t.isFunctionExpression(opt) && !t.isArrowFunctionExpression(opt) && !t.isObjectExpression(opt)) { + debug.definePage(`definePage() 参数仅支持函数或对象: ${filename}`) + return + } + return call + } + } + return }
🧹 Nitpick comments (1)
packages/core/src/page.ts (1)
140-148: Behavior change: multiple definePage calls are now silently ignored after the first—confirm intent.Previously duplicates errored; now extras remain in code. In transform(), only the first match is removed from the source, so subsequent definePage calls (if any) might ship to output. Confirm this is intended; otherwise consider warning/throwing on a second occurrence or removing all occurrences while keeping the first for evaluation.
Happy to add tests covering: single macro, multiple macros (ensure chosen one and residual handling), none present.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/core/src/page.ts(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/core/src/page.ts (2)
packages/core/src/utils.ts (1)
debug(23-33)packages/core/src/index.ts (1)
transform(86-143)
🔇 Additional comments (1)
packages/core/src/page.ts (1)
159-159: Log message language consistency.You switched to a Chinese debug string. Is the project standardizing on zh-CN for logs? If not, align message language.
2 participants
Description 描述
找到第一个 definePage 就跳出 loop，无须遍历整个 ast
Summary by CodeRabbit