fix(types): change definePage to global scope

[xiaohe0601]

Description 描述

修复 definePage 全局声明错误，原来的写法需要 import 使用。

declare global {
  const definePage: import('.').DefinePage
}

export {}

参考 @vue/runtime-core：

declare global {
  const defineProps: _defineProps
  const defineEmits: _defineEmits
  const defineExpose: _defineExpose
  const defineOptions: _defineOptions
  const defineSlots: _defineSlots
  const defineModel: _defineModel
  const withDefaults: _withDefaults
}

Summary by CodeRabbit

• Bug Fixes
  • Improved TypeScript compatibility for the global page definition helper, resolving typing errors and enhancing IntelliSense/autocomplete in various setups.
• Refactor
  • Streamlined global type declarations to align with TypeScript best practices, improving editor and tooling reliability without affecting runtime behavior.

[coderabbitai]

Walkthrough

Updated TypeScript global augmentation for definePage in packages/core/client.d.ts, switching from globalThis namespace augmentation to a declare global block. The DefinePage type import path is unchanged. Other declarations remain intact, and the file still ends with export {}.

Changes

Cohort / File(s)	Change summary
Global type augmentation update packages/core/client.d.ts	Replaced declare namespace globalThis { export const definePage: import('.')\.DefinePage } with declare global { const definePage: import('.')\.DefinePage }; retained other declarations and trailing export {}.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my nose at types that roam,
Hop-hop, I bring definePage home.
From globalThis to global glade,
A softer burrow has been made.
Carrots aligned, exports tight—
Compile burrows warm tonight. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 90b46ff and 9a5c0fd.

📒 Files selected for processing (1)

• packages/core/client.d.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

packages/core/client.d.ts (2)

packages/core/src/index.ts (1)

• transform (86-143)

packages/core/src/page.ts (2)

• Page (14-73)
• hasChanged (34-37)

🔇 Additional comments (2)

packages/core/client.d.ts (2)

9-11: Macro is now truly global; matches Vue’s macros pattern.

declare global { const definePage: import('.').DefinePage } is the right shape for a global macro and avoids import requirements in user code. Good alignment with @vue/runtime-core’s declarations.

---

13-13: Keep export {} to ensure module context for declare global.

Required so the file is treated as a module; otherwise global augmentation won’t apply reliably.

[FliPPeDround]

那这样的话，
https://github.com/uni-helper/vite-plugin-uni-pages/blob/main/packages/core/index.d.ts
这个文件还有存在的必要性吗
我更希望引入的类型文件的路径为@uni-helper/vite-plugin-uni-pages，能少写个client最好

[xiaohe0601]

有这个文件那 tsconfig 就可以不加 client 了，没注意看到这个 🙃