Skip to content

Conversation

@Frawless
Copy link
Member

This PR bump several dependencies to allow us use @ParametrizedClass from junit6 to run our ITs against multiple Kafka versions.

Closes #1037

@Frawless Frawless added this to the 0.34.0 milestone Dec 18, 2025
@Frawless
Copy link
Member Author

[INFO] Results:
[INFO] 
[WARNING] Tests run: 514, Failures: 0, Errors: 0, Skipped: 3

vs

[INFO] Results:
[INFO] 
[WARNING] Tests run: 133, Failures: 0, Errors: 0, Skipped: 3

The log shows that different versions of Kafka was used for spin-up strimzi-test-container. There are also some admin-client logs after test exuction is done so we probably do not stop everything properly? I am not sure if it comes from bridge or from the tests:

2025-12-18 17:01:16 INFO  [kafka-admin-client-thread | adminclient-106] AppInfoParser:89 - App info kafka.admin.client for adminclient-106 unregistered
2025-12-18 17:01:16 INFO  [kafka-admin-client-thread | adminclient-106] Metrics:684 - Metrics scheduler closed
2025-12-18 17:01:16 INFO  [kafka-admin-client-thread | adminclient-106] Metrics:688 - Closing reporter io.strimzi.kafka.metrics.KafkaPrometheusMetricsReporter
2025-12-18 17:01:16 INFO  [kafka-admin-client-thread | adminclient-106] Metrics:694 - Metrics reporters closed
2025-12-18 17:01:16 INFO  [vert.x-eventloop-thread-0] HttpBridge:341 - HTTP bridge has been shut down successfully
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.978 s -- in io.strimzi.kafka.bridge.http.TlsIT
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.25 s -- in io.strimzi.kafka.bridge.http.TlsIT
[INFO] 
[INFO] Results:
[INFO] 
[WARNING] Tests run: 514, Failures: 0, Errors: 0, Skipped: 3
[INFO] 
[INFO] 
[INFO] --- failsafe:3.5.4:verify (default) @ kafka-bridge ---
[INFO] Failsafe report directory: /home/vsts/work/1/s/target/failsafe-reports
2025-12-18 17:01:16 INFO  [kafka-admin-client-thread | adminclient-20] NetworkClient:1072 - [AdminClient clientId=adminclient-20] Node -1 disconnected.
2025-12-18 17:01:16 WARN  [kafka-admin-client-thread | adminclient-20] NetworkClient:899 - [AdminClient clientId=adminclient-20] Connection to node -1 (localhost/127.0.0.1:32786) could not be established. Node may not be available.
2025-12-18 17:01:16 INFO  [kafka-admin-client-thread | adminclient-34] NetworkClient:1072 - [AdminClient clientId=adminclient-34] Node -1 disconnected.
2025-12-18 17:01:16 WARN  [kafka-admin-client-thread | adminclient-34] NetworkClient:899 - [AdminClient clientId=adminclient-34] Connection to node -1 (localhost/127.0.0.1:32800) could not be established. Node may not be available.
[INFO] 
[INFO] --- dependency:3.3.0:analyze-only (analyze) @ kafka-bridge ---

@Frawless Frawless marked this pull request as ready for review December 22, 2025 08:13
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@TestInstance(TestInstance.Lifecycle.PER_CLASS)
@ParameterizedClass
// These are Kafka versions supported by Strimzi Test Container. Should be updated together with test-container version bump.
@ValueSource(strings = {"4.0.0", "4.0.1", "4.1.0", "4.1.1"})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if it was already discussed...I wonder if it would be easier to have a method inside the test container (something like getSupportedKafkaVersions()). This way, we would only bump the version of TC and avoid modifying this part as well...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @ppatierno pointed on it on slack, afaiu it is not possible now and it will required new release. I can open issue to track it. It will be great to have it, but I don't think it should block this PR given that new release of TC will be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Integration tests with multiple Kafka versions supported by test container

4 participants