-
Notifications
You must be signed in to change notification settings - Fork 134
Make HttpBridgeITAbstract parametrized to run tests against multiple Kafka versions #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…Kafka versions Signed-off-by: Jakub Stejskal <[email protected]>
vs The log shows that different versions of Kafka was used for spin-up strimzi-test-container. There are also some admin-client logs after test exuction is done so we probably do not stop everything properly? I am not sure if it comes from bridge or from the tests: |
scholzj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
ppatierno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
| @TestInstance(TestInstance.Lifecycle.PER_CLASS) | ||
| @ParameterizedClass | ||
| // These are Kafka versions supported by Strimzi Test Container. Should be updated together with test-container version bump. | ||
| @ValueSource(strings = {"4.0.0", "4.0.1", "4.1.0", "4.1.1"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if it was already discussed...I wonder if it would be easier to have a method inside the test container (something like getSupportedKafkaVersions()). This way, we would only bump the version of TC and avoid modifying this part as well...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @ppatierno pointed on it on slack, afaiu it is not possible now and it will required new release. I can open issue to track it. It will be great to have it, but I don't think it should block this PR given that new release of TC will be needed.
This PR bump several dependencies to allow us use
@ParametrizedClassfrom junit6 to run our ITs against multiple Kafka versions.Closes #1037