Add support for additional volumes and volume mounts (with fixes)

[mattjohnson]

Summary

This PR adds support for configuring additional volumes and volume mounts on the IQ Server main container, based on the work in PR #51 by @sleyer.

This implementation includes several improvements and fixes to ensure the feature produces clean, idiomatic Kubernetes YAML and has accurate documentation.

Changes

Feature Implementation (from PR #51)

• ✅ Add extraVolumes configuration supporting:
  • persistentVolumeClaim (via existingClaim)
  • hostPath
  • configMap
  • secret
  • emptyDir (with optional parameters)
• ✅ Add extraVolumeMounts configuration with:
  • Required: name, mountPath
  • Optional: subPath, readOnly
• ✅ Comprehensive helm unit tests for both features
• ✅ Example configurations in values.yaml

Improvements & Fixes

1. Fixed volumeMounts rendering (Critical)

   • Previously rendered empty values for optional fields: subPath: "" and readOnly:
   • Now properly omits optional fields when not specified
   • Uses hasKey check for readOnly to handle explicit false values
   • Produces cleaner, more idiomatic Kubernetes YAML

2. Fixed documentation errors

   • Corrected typo: subpath → subPath (capital P)
   • Fixed incorrect comment about readOnly default (Kubernetes defaults to false/read-write, not true)

3. Updated test expectations

   • Removed incorrect null assertions for optional fields
   • Tests now properly validate that fields are omitted when not specified

4. Improved test metadata

   • Updated suite names to accurately reflect what's being tested
   • Removed trailing whitespace and added proper newlines

Testing

All changes verified with:

• ✅ helm lint chart/ - passes with no errors
• ✅ Template rendering tests with minimal configuration (only required fields)
• ✅ Template rendering tests with all fields specified
• ✅ All volume types tested (secret, configMap, etc.)

Example Rendering

Before (with fixes):

# Minimal configuration - clean output
- name: test-mount
  mountPath: /test/path

# With all options - everything renders correctly
- name: test-mount
  mountPath: /test/path
  subPath: mysubpath
  readOnly: false

Previously:

# Minimal configuration - had empty values
- name: test-mount
  mountPath: /test/path
  subPath: 
  readOnly: 

Use Case

This feature enables users to mount custom certificates, configuration files, or other resources into the IQ Server container via ConfigMaps, Secrets, or other Kubernetes volume types.

Related

• Based on: Make additional volumes and volume mounts on main container settable #51 by @sleyer
• Co-authored-by: Sascha Leyer [email protected]

Checklist

• Code changes are tested and verified
• Helm lint passes
• Template rendering produces valid YAML
• Documentation is accurate
• Test files are clean and properly formatted
• Original author attribution preserved

[jawadshaikst]

+1