Fix fluentd image registry configuration for sidecar container #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…35225 Problem: The fluentd sidecar container in iq-server-deployment.yaml was not respecting the fluentd.image.registry value from values.yaml, causing image pull failures when customers specified a custom registry. Solution: 1. Added a new helper function 'nexus-iq-server-ha.fluentdImage' in _helpers.tpl that includes the registry in the image path when set 2. Updated iq-server-deployment.yaml to use the helper function 3. Added tests to verify the fix works with and without custom registry This fix maintains backward compatibility - customers without a custom registry will continue to work as before. Fixes: CLM-35225
The fluentd subchart's default values include the docker.io registry prefix in the image path. Updated test assertions to match the actual rendered output.
codetreras
reviewed
Oct 27, 2025
| - name: FLUENTD_DAEMON_GROUP | ||
| value: fluentd | ||
| image: bitnami/fluentd:1.18.0-debian-12-r0 | ||
| image: docker.io/bitnami/fluentd:1.18.0-debian-12-r0 |
There was a problem hiding this comment.
I'm not sure if the registry should be included here, if not registry is defined, docker.io is not added by default according to the helper function.
Collaborator
Author
There was a problem hiding this comment.
I think this is because the helper changes it to default to the full name, instead of an implied default registry, and thats what is defined in the default values for the subchart https://artifacthub.io/packages/helm/bitnami/fluentd?modal=values
codetreras
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the fluentd sidecar container in the iq-server deployment was not respecting the
fluentd.image.registryvalue fromvalues.yaml, preventing customers from specifying a custom container registry for their fluentd images.Problem
The Helm chart specifies the Fluentd container image in two locations when Fluentd is enabled:
registry,repository, andtag)iq-serversidecar container (only usedrepositoryandtag)This prevented users from specifying a custom image registry for the sidecar, leading to inconsistent image sources and potential image pull errors when using private registries.
Solution
nexus-iq-server-ha.fluentdImagein_helpers.tplthat includes the registry in the image path when setiq-server-deployment.yamlto use the helper function instead of direct template referencesBackward Compatibility
This change maintains full backward compatibility. The helper function checks if
fluentd.image.registryis set:private-registry.example.com/bitnami/fluentd:1.18.0)docker.io/bitnami/fluentd:1.18.0)Customers without a custom registry will continue to work as before.
Testing
Customer Impact
Resolves issues for customers who use private or custom container registries for their Fluentd images, enabling consistent registry configuration across all Fluentd instances managed by the chart.