Skip to content

fix bug about changing admin email or phonenumber online #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cui-ying wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bug about changing admin email or phonenumber online #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions cachecloud-open-common/src/main/java/com/sohu/cache/web/component/EmailComponentImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,9 @@
public class EmailComponentImpl implements EmailComponent {
private final Logger logger = LoggerFactory.getLogger(EmailComponentImpl.class);

private String adminEmail = ConstUtils.EMAILS;

@Override
public boolean sendMailToAdmin(String title, String content) {
return sendMail(title, content, Arrays.asList(adminEmail));
return sendMail(title, content, Arrays.asList(ConstUtils.EMAILS));
}

@Override
Expand Down Expand Up @@ -60,15 +58,9 @@ public boolean sendMail(String title, String content, List<String> emailList, Li
}
}

public void setAdminEmail(String adminEmail) {
this.adminEmail = adminEmail;
}

@Override
public String getAdminEmail() {
return adminEmail;
return ConstUtils.EMAILS;
}



}
23 changes: 8 additions & 15 deletions ...loud-open-common/src/main/java/com/sohu/cache/web/component/MobileAlertComponentImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
package com.sohu.cache.web.component;

import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import com.sohu.cache.util.ConstUtils;
import com.sohu.cache.web.util.HttpRequestUtil;
import org.apache.commons.lang.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import com.sohu.cache.util.ConstUtils;
import com.sohu.cache.web.util.HttpRequestUtil;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

/**
* 手机短信报警
Expand All @@ -21,13 +20,11 @@
public class MobileAlertComponentImpl implements MobileAlertComponent {

private final Logger logger = LoggerFactory.getLogger(MobileAlertComponentImpl.class);
/**
* 管理员电话
*/
private String adminPhones = ConstUtils.PHONES;


@Override
public void sendPhoneToAdmin(String message) {
String adminPhones = ConstUtils.PHONES; // 管理员电话
if (StringUtils.isBlank(message) || StringUtils.isBlank(adminPhones)) {
logger.error("message is {}, maybe empty or adminPhones is {}, maybe empty", message, adminPhones);
}
Expand Down Expand Up @@ -57,8 +54,4 @@ public void sendPhone(String message, List<String> phoneList) {
logger.warn("send Done!");
}

public void setAdminPhones(String adminPhones) {
this.adminPhones = adminPhones;
}

}