Add storage images and support for store and querying image size #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btipling
commented
Aug 13, 2025
| result_t = NULL; | ||
| } else if (t) { | ||
| result_t = qualified_type_helper(a, shd_scope, t); | ||
| } |
Author
There was a problem hiding this comment.
So I think I had to make this change because imageStore has a void return type? I don't know if this is correct.
Hugobros3
reviewed
Aug 13, 2025
vcc/include/shady.h
Outdated
| native_vec4 texture3D(const sampler3D, native_vec3) __asm__("shady::impure_op::spirv.core::87::Invocation"); | ||
| native_vec4 textureCube(const samplerCube, native_vec3) __asm__("shady::impure_op::spirv.core::87::Invocation"); | ||
|
|
||
| native_ivec2 imageSize(image2D img) __asm__("shady::pure_op::spirv.core::104::Invocation"); |
Collaborator
There was a problem hiding this comment.
this PR would make a lot more sense if this also included the load ops
Author
There was a problem hiding this comment.
@Hugobros3 my bad, I realized looking at the rest of the header file that I hadn't done a very good job here. I hope the changes I have made in 59b1adf (and the other commits) are an improvement.
Author
There was a problem hiding this comment.
btipling
force-pushed
the
bt/add_image_2d_ops
branch
from
7446c89 to
ef4a9c7
Compare
btipling
force-pushed
the
bt/add_image_2d_ops
branch
from
9b733ad to
d4407ab
Compare
Collaborator
|
FYI: #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.