Skip to content

feat(Message): create Message#getCommand method #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yvasyliev wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

feat(Message): create Message#getCommand method #1518

yvasyliev wants to merge 9 commits into from

Conversation

@yvasyliev
Copy link

@yvasyliev yvasyliev commented Jun 20, 2025

Message#isCommand felt lonely, so I added Message#getCommand for company

@yvasyliev yvasyliev changed the base branch from master to dev June 21, 2025 13:48
rubenlagus
rubenlagus reviewed Jul 23, 2025
View reviewed changes
telegrambots-meta/src/main/java/org/telegram/telegrambots/meta/api/objects/message/Message.java Outdated
public String getCommand() {
return Stream.ofNullable(entities)
.flatMap(Collection::stream)
.filter(entity -> entity != null && NumberUtils.INTEGER_ZERO.equals(entity.getOffset()))
Copy link
Owner

@rubenlagus rubenlagus Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need a whole new import to check a number vs 0

Copy link
Author

@yvasyliev yvasyliev Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing wrong with importing constants. It's a bad practice to use magic numbers.

@yvasyliev yvasyliev requested a review from rubenlagus July 24, 2025 09:44
@rubenlagus rubenlagus force-pushed the dev branch 3 times, most recently from 52a184e to 9203912 Compare September 7, 2025 22:52
@yvasyliev
feat(Message): replace Java Stream block with plain for loop for be…
22efa2f 
…tter performance in `Message#getCommand` method
@yvasyliev
Copy link
Author

yvasyliev commented Dec 27, 2025 •
edited
Loading

Hi @rubenlagus

  1. I replaced the Stream block with plain for loop for slightly better performance.
  2. entity.offset is an Integer, meaning just comparing it to 0 is not null-safe. Still NumberUtils.INTEGER_ZERO could be handy here (commons-lang3 is already included into the project). I decided to put Objects.equals(entity.getOffset(), 0) instead of entity.getOffset() != null && entity.getOffset() == 0 if that's fine.

Could you please review the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenlagus rubenlagus Awaiting requested review from rubenlagus

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yvasyliev @rubenlagus