feat: trigger Deployment & StatefulSet restart on VaultSecret update #319
+189
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaelapteanu
force-pushed
the
feat_restart_on_secret_change
branch
from
1022651 to
091dd4b
Compare
Author
|
@ricoberger mind taking a look? |
Owner
|
Hi @nicolaelapteanu, thanks for your contribution 🙂 I'm not sure, if this feature should be part of the operator. We are using https://github.com/stakater/Reloader for this purpose, which also works for ConfigMaps / Secrets not created by the operator. Would this also be an option for you? |
Author
|
Frankly speaking, this is your tool and your design choice, so I'll defer to your judgment. Feel free to close the PR if you decide not to include this feature in the operator. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.