-
Notifications
You must be signed in to change notification settings - Fork 4
Revert API Url in Dev to localhost
#108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ca0fed1 to
d6c25c3
Compare
|
@GreenWithMV this shouldn't really matter all that much, but may be a little confusing for new members of the group getting setup having this ENV hit production's API by default. |
|
Would this need to get added to the readme? Because if I just want to edit frontend I will need to know that I need to clone that repo or revert back to directing to the live backend |
|
@GreenWithMV great point! What if we add a third ENV variable that's something like Then we can add something like this to the README: When running the application locally you must connect to a valid API for handling requests. You can either utilize a local backend server or the production website. To toggle between these configurations, update the the following line in your To Use Locally Hosted API To Use Production Website's API |
|
I think that sounds good, thanks Tim! |
d6c25c3 to
0ec52cc
Compare
|
Great @GreenWithMV! Just updated based on what we discussed. Should be ready for a review now 👍 |
e7fbfe0 to
7dabac8
Compare
|
@GreenWithMV I'm going to look to revisit/merge this after the Friends PR. There's a few README updates coming in from that work so it will be good to handle this after (especially as it's very low priority). |
Introduces another ENV variable to specify which API URL should be utilize for the backend connection. Currently acts as a soft-override to the configuration when running locally/non-production.
7dabac8 to
48d30b1
Compare
|
@GreenWithMV this should be ready for review/good to merge now 👍 |
Description
Reverts the
.envfile's storedREACT_APP_DEV_API_URLENV variable to the expected local URL.Screenshots (if appropriate):
N/A
Types of changes
N/A - best practice / documentation improvements