add event-emitter support across transport #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
| * | ||
| * @param {String} event | ||
| * @param {*} ...args | ||
| */ |
Member
There was a problem hiding this comment.
It seems that emit now writes on the underlying connection but also emit the event to the instance it is called from. It looks wrong to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love substream and primus thanks for the modules!
This is a working attempt of adding event-emitter support to substreams (so that they emit events across the wire)
I am not super knowledgeable w/ substream, so please let me know if there are any side effects. Currently I am ignoring
dataandendevents because they are already handled by substream.I am also, unsure how you would like
errorevents to be emitted across the wire. I was thinking of using http://npmrepo.com/error-to-json to convert the error to json before sending it over the wire, and then parsing as an error on the receiving end.Let me know what you think.
Thanks!