Skip to content

Conversation

@nimish-ks
Copy link
Member

@nimish-ks nimish-ks commented Nov 11, 2024

🔍 Overview

Add support for syncing secrets to Vercel environments. This integration allows users to sync their Phase secrets to Vercel projects across different environments (production, preview, development) with configurable secret types.

💡 Proposed Changes

  • Add Vercel integration backend with support for:
    • Credential validation
    • Project listing
    • Secret syncing with different visibility types
  • Add frontend components for Vercel sync configuration
  • Add GraphQL mutations and queries for Vercel integration
  • Add new service type in ServiceConfig

🖼️ Screenshots or Demo

Screenshot From 2024-11-12 11-56-52
Screenshot From 2024-11-12 11-57-13
Screenshot From 2024-11-12 11-57-46
Screenshot From 2024-11-12 11-58-44

📝 Release Notes

Added

  • New Vercel integration for secret syncing
  • Support for different Vercel environments (production, preview, development, all)
  • Multiple secret visibility options (plain, encrypted, sensitive)
  • Vercel project selection with search functionality

Docs

Draft: phasehq/docs#98

🎯 Reviewer Focus

Please focus on:

  1. Credential validation flow
    • Test with valid Vercel tokens
    • Test with invalid/expired tokens
    • Test with non-Vercel credentials
  2. Secret type handling
    • Verify plain text secrets are visible in Vercel UI
    • Verify encrypted secrets are hidden but accessible
    • Verify sensitive secrets are completely hidden
  3. Environment targeting
    • Test syncing to specific environments (prod/preview/dev)
    • Test syncing to all environments
    • Verify environment-specific secrets are isolated

✨ How to Test the Changes Locally

  1. Add Vercel credentials in Phase:
  2. Create a new sync:
    • Select a Phase environment
    • Choose your Vercel project
    • Select target environment and secret type
  3. Add secrets and verify they appear in your Vercel project settings

💚 Did You...

  • Ensure linting passes (code style checks)
  • Update dependencies and lockfiles (if required)
  • Regenerate graphql schema and types (if required)
  • Verify the app builds locally
  • Manually test the changes on different browsers/devices

@nimish-ks nimish-ks self-assigned this Nov 11, 2024
@nimish-ks nimish-ks marked this pull request as draft November 11, 2024 17:25
@nimish-ks nimish-ks marked this pull request as ready for review November 12, 2024 07:17
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Seems to work flawlessly, Just a few minor suggestions.

@nimish-ks nimish-ks merged commit 58a44ba into main Nov 12, 2024
6 checks passed
@nimish-ks nimish-ks deleted the feat--vercel-integration branch November 12, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants