8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests #28208
+19
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
The DockerTestUtils.RETAIN_IMAGE_AFTER_TEST variable which read the property from "jdk.test.docker.retain.image" do not work for some of the docker tests, such as jdk/internal/platform/docker/TestDockerCpuMetrics.java, only works for some of the docker tests, such as jdk/internal/platform/docker/TestPidsLimit.java.
This PR read the DockerTestUtils.RETAIN_IMAGE_AFTER_TEST inside function removeDockerImage instead of before all the fucntion removeDockerImage. This will make all the docker tests receive the property jdk.test.docker.retain.image.
Change has been verified locally on linux-x64 by run the all touched tests.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28208/head:pull/28208$ git checkout pull/28208Update a local copy of the PR:
$ git checkout pull/28208$ git pull https://git.openjdk.org/jdk.git pull/28208/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28208View PR using the GUI difftool:
$ git pr show -t 28208Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28208.diff
Using Webrev
Link to Webrev Comment