Skip to content

Conversation

@giando332994
Copy link
Contributor

frontend fix: connect button in popup with correct url, quota calculation fixed with all the environments in the template

Description

This PR fixes issue #1005 correcting the url in the popup when the instance is ready and fixed the quota calculations with all the environments in the template
Fixes #1005 (issue)

…url, quota calculation updated with all the environments in the template
@giando332994 giando332994 requested a review from a team as a code owner December 2, 2025 17:36
@kingmakerbot
Copy link
Collaborator

Hi @giando332994. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@frisso
Copy link
Member

frisso commented Dec 2, 2025

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-1016 label to your tenant.

@frisso
Copy link
Member

frisso commented Dec 3, 2025

@AleTopp This PR works for me.
Comments? Otherwise we can merge.

@QcFe
Copy link
Collaborator

QcFe commented Dec 3, 2025

@giando332994 thanks for the PR, I had a quick look at the code but I'm missing if/where it's checked for multi-environment and if so the connect button is omitted.

@giando332994
Copy link
Contributor Author

@QcFe I missed it, in the current status only the single environment instance is fixed.
Should I remove the connect button in multi-env case? Or for example point to the first gui enabled environment

@QcFe
Copy link
Collaborator

QcFe commented Dec 3, 2025

I think it's easier just omit the connect button

@frisso frisso merged commit c9d20d9 into netgroup-polito:master Dec 3, 2025
33 checks passed
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Button "connect" in notification fails

4 participants