Skip to content

Conversation

@frisso
Copy link
Member

@frisso frisso commented Nov 29, 2025

Fix issue: #1017

@frisso frisso requested a review from a team as a code owner November 29, 2025 07:27
@kingmakerbot
Copy link
Collaborator

Hi @frisso. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@AleTopp
Copy link
Contributor

AleTopp commented Nov 29, 2025

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-1011 label to your tenant.

@frisso frisso marked this pull request as draft December 1, 2025 14:33
@abellonioandrea
Copy link
Collaborator

I don't know why, but I tried with Safari on MacBook Pro 13 inch and it's not working, but on Firefox on the same pc works fine...

@AleTopp
Copy link
Contributor

AleTopp commented Dec 1, 2025

On Firefox on Win 10, I see it still flickering. And if you check the PR code nothing was edited for the flickering

@abellonioandrea
Copy link
Collaborator

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-1011 label to your tenant.

@abellonioandrea abellonioandrea marked this pull request as ready for review December 3, 2025 17:25
@AleTopp
Copy link
Contributor

AleTopp commented Dec 3, 2025

Now I see it fine! Thanks

@abellonioandrea
Copy link
Collaborator

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-1011 label to your tenant.

Copy link
Contributor

@AleTopp AleTopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frisso frisso merged commit 17021bc into master Dec 4, 2025
34 checks passed
@frisso frisso deleted the frs/logout-button branch December 4, 2025 14:38
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants