Skip to content

feat: QoL browse tab changes #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: QoL browse tab changes #2278

wants to merge 1 commit into from

Conversation

@D-Brox
Copy link
Contributor

@D-Brox D-Brox commented Aug 29, 2025 •
edited
Loading

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 29, 2025
View reviewed changes
app/src/main/java/eu/kanade/tachiyomi/ui/source/browse/BrowsePresenter.kt
}

fun getSearchPage() {
fun getSearchPage(keepBacktrack: Boolean = false) {

Check warning

Code scanning / detekt

One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning

The function getSearchPage is too long (243). The maximum length is 60.
app/src/main/java/eu/kanade/tachiyomi/ui/source/browse/BrowsePresenter.kt
}

fun getSearchPage() {
fun getSearchPage(keepBacktrack: Boolean = false) {

Check warning

Code scanning / detekt

Prefer splitting up complex methods into smaller, easier to understand methods. Warning

The function getSearchPage appears to be too complex (24). Defined complexity threshold for methods is set to '15'
@nonproto
Copy link
Collaborator

nonproto commented Aug 29, 2025

So I agree with what is being done, but i don't know if i want to address it until library compose is done, Once that is done I can migrate to nav3 instead of using controllers, as every other screen is compose now.

Few issues i saw.

  1. It adds a top nav back, on a screen that shouldn't be able to go back. J2K handles this by not showing bottom nav, so it doesnt seem to be a top nav anymore. Which is probably how i would handle it post new navigation.
  2. There is broken functionality if you do the following. Library -> search author -> click author -> click a manga -> search a tag. It still shows you are in author at the top and the bottom sheet for search doesn't have the correct values at all, the top nav only goes back to the last manga clicked and not all the way back to the original one.

@D-Brox
Copy link
Contributor Author

D-Brox commented Aug 29, 2025

Since the footer part is independent, I guess I'll split the PR instead and wait for the nav migration for the backtrack feature

@D-Brox D-Brox marked this pull request as draft August 29, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@D-Brox @nonproto