-
Notifications
You must be signed in to change notification settings - Fork 67
Add Docker image build for MCP server #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add CI workflow to build and push Docker image on release tags - Add Dockerfile for standalone MCP server container - Add local build target (make mcp-server-docker) - Add documentation for Docker usage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 LLM Evaluation ResultsOpenAI
❌ Failed EvaluationsShow 2 failuresOPENAI1. TestChannelSummarization/[openai]_channel_summarization_developers_webapp_channel
2. TestChannelSummarization/[openai]_channel_summarization_developers_webapp_channel
Anthropic
❌ Failed EvaluationsShow 1 failuresANTHROPIC1. TestConversationMentionHandling/[anthropic]_conversation_from_attribution_long_thread.json
Azure OpenAI✅ Overall: 21/21 tests passed (100.0%)
Mistral✅ Overall: 19/19 tests passed (100.0%)
AWS Bedrock✅ Overall: 25/25 tests passed (100.0%)
This comment was automatically generated by the eval CI pipeline. |
NARSimoes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just adding a few points for discussion - overall this looks good.
| runs-on: ubuntu-latest | ||
| if: startsWith(github.ref, 'refs/tags/v') | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider using commit SHA pointing to a specific commit for better reproducibility. For example, instead of actions/[email protected] we can use something like actions/checkout@ 8e8c483db84b4bee98b60c0593521ed34d9990e8 #v6.0.1. The same applies for there steps.
| - name: ci/extract-version | ||
| id: version | ||
| run: echo "version=${GITHUB_REF#refs/tags/v}" >> $GITHUB_OUTPUT | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding a step to scan the Dockerfile & images on pull-request and before pushing to the repository. With that we can catch issues earlier in CI and before those images are published.
| docker-mcp-server-build-push: | ||
| runs-on: ubuntu-latest | ||
| if: startsWith(github.ref, 'refs/tags/v') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about breaking this down to also validate the Dockerfile in pull-requests ? For example, something like:
- On
pull-requests: checkout -> build -> scan / lint / test Dockerfile & images - On
github.ref, 'refs/tags/v': push the images
Summary
make mcp-server-dockertarget for local buildsTest plan
make mcp-server-docker🤖 Generated with Claude Code