Fix "Cannot read properties of undefined (reading 'username')" #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes MM-66699 where users encountered "Cannot read properties of undefined (reading 'username')" when sending their first message in the RHS. Root Cause: When the RHS is opened for the first time and a direct channel is created using Client4.createDirectChannel(), the user profiles are not automatically loaded into the Redux store. The Mattermost AdvancedTextEditor component requires access to state.entities.users.profiles[userId] to create posts, but this data was missing on first use. Solution: After creating the direct channel, we now: 1. Fetch the current user profile using Client4.getMe() 2. Fetch the bot user profile using Client4.getUser(botId) 3. Dispatch RECEIVED_PROFILES action to add both profiles to Redux store This ensures AdvancedTextEditor has access to the necessary user data when creating the first post. Changes: - webapp/src/client.tsx: Export Client4 instance - webapp/src/components/rhs/rhs_new_tab.tsx: Load and dispatch user profiles after channel creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MM-66699 where users encountered "Cannot read properties of undefined (reading 'username')" when sending their first message in the RHS.
Root Cause:
When the RHS is opened for the first time and a direct channel is created using Client4.createDirectChannel(), the user profiles are not automatically loaded into the Redux store. The Mattermost AdvancedTextEditor component requires access to state.entities.users.profiles[userId] to create posts, but this data was missing on first use.
Solution:
After creating the direct channel, we now:
This ensures AdvancedTextEditor has access to the necessary user data when creating the first post.
Changes:
Ticket Link
https://mattermost.atlassian.net/browse/MM-66699
Release Note