Support pathType in Ingress #492
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
stafot
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for overriding the ingress pathType for Mattermost Teams, allowing users to configure more advanced path-based routing options.
- Introduces a new ingress.pathType field in values.yaml with a default of "Prefix".
- Updates the ingress template to use the configurable pathType for Kubernetes networking version v1.
- Enhances README documentation to include details on the new ingress.pathType parameter.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/mattermost-team-edition/values.yaml | Adds a configurable ingress.pathType value with default "Prefix". |
| charts/mattermost-team-edition/templates/ingress.yaml | Updates template to use the new ingress.pathType parameter for Kubernetes networking v1. |
| charts/mattermost-team-edition/README.md | Documents the new ingress.path and ingress.pathType parameters. |
Comments suppressed due to low confidence (3)
charts/mattermost-team-edition/values.yaml:61
- Consider adding a comment that explains the allowed values for ingress.pathType (e.g., 'Prefix', 'Exact', 'ImplementationSpecific') to assist future maintainers.
pathType: Prefix
charts/mattermost-team-edition/README.md:139
- Consider adding a brief note on the README about the available options for ingress.pathType (e.g., 'Prefix', 'Exact', 'ImplementationSpecific') to guide users in choosing the appropriate value.
`ingress.pathType` | The ingress path type | `Prefix`
charts/mattermost-team-edition/templates/ingress.yaml:34
- Verify that using the ingress.pathType parameter outside of the API version conditional block is intentional, ensuring that the newer Kubernetes version logic is clearly separated from legacy behavior.
pathType: {{ $.Values.ingress.pathType }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Ingress template for Mattermost Teams does not presently support overriding the
pathType. In order to use Nginx path-based routing with regex's etc, you need to be able to specifypathType: ImplementationSpecificTicket Link
Relates to #491