Skip to content

Conversation

@27136773
Copy link
Contributor

@27136773 27136773 commented Oct 29, 2023

Goal: Combined Import/Export for Bookmarks and Flags

  • Remove global singleton access of ItemflagManager from BookmarkPlugin
  • Revise the update for each entry in BookmarkPlugin
  • Revise interface and shrink code in ItemflagManager
  • Update tests and test cases
  • Adjust frontend

@Sheepux Sheepux requested a review from Copilot November 22, 2024 13:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 13 changed files in this pull request and generated no suggestions.

Files not reviewed (8)
  • web/src/frontend/classic/components/Media.svelte: Language not supported
  • web/src/frontend/classic/components/MediaItem.svelte: Language not supported
  • web/src/frontend/classic/components/MediaItemSelect.svelte: Language not supported
  • web/src/frontend/classic/components/Suggestions.svelte: Language not supported
  • web/src/frontend/classic/components/content-pages/Bookmarks.svelte: Language not supported
  • web/src/frontend/classic/components/viewer/Viewer.svelte: Language not supported
  • web/src/engine/providers/Bookmark.ts: Evaluated as low risk
  • web/src/engine/providers/BookmarkPlugin.ts: Evaluated as low risk

@27136773 27136773 removed the Engine label Dec 10, 2024
@Sheepux Sheepux added the Engine label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants