Add Japanese translations and related UI updates #1173
Conversation
hayato-444
force-pushed
the
add-ja-translations
branch
from
c2bd256 to
241b128
Compare
There was a problem hiding this comment.
This file must not be manipulated manually.
This file is automatically generated and updated via Crowdin, all translations must be performed via the Crowdin platform.
|
Address Coding and Test Errors |
There was a problem hiding this comment.
Make sure to also add/update tests in Localization_test.ts
| <Tag type="cyan"> | ||
| ({results.found}) | ||
| </Tag> found | ||
| </Tag> {$Locale.Frontend_Classic_Bookmark_Found().replace('{0}', String(results.found))} |
There was a problem hiding this comment.
Do not perform the replacements manually, let the localization provider do the correct formatting
$Locale.Frontend_Classic_Bookmark_Found(`${results.found}`)
There was a problem hiding this comment.
Other places in this PR as well
| Frontend_Classic_Bookmark_ExportDone: "Export completed", | ||
| Frontend_Classic_Bookmark_UserCanceled: "User canceled", | ||
| Frontend_Classic_Bookmark_Error: "Error: {error}", | ||
| Frontend_Classic_Bookmark_Found: "found", |
There was a problem hiding this comment.
This seems to be missing the placeholder {0} for additional parameter of bookmark count
|
Suggestion to reject this PR after Sunday, 17 August 2025 (12 weeks) if not approved by a reviewer. |
2 participants
Overview
Added comprehensive Japanese translations and integrated them into the application UI.
Covered areas:
Details
web/src/i18n/locales/ja_JP.tsILocale.ts,Localization.ts,_invariant.ts,en_US.ts.sveltecomponents infrontend/classicto support the new localeNotes
masterto remove unrelated changes and ensure a clean diff.