refactor: add type hints to parser library and Laravel facades #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type hints to SignatureValidator::validateSignature() parameters and return type - Replace docblock annotations with PHP 8.1+ property type declarations in ParsedEvents This improves type safety and modernizes the code to use PHP 8.1+ features.
Add return type hint (: string) to all Laravel facade getFacadeAccessor() methods: - LINEChannelAccessTokenApi - LINEInsightApi - LINELiffApi - LINEManageAudienceApi - LINEManageAudienceBlobApi - LINEMessagingApi - LINEMessagingBlobApi This improves type safety and IDE support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type hints and property type declarations to improve type safety.
Parser Library:
SignatureValidator::validateSignature()parameters and return typeParsedEventsLaravel:
: stringto all facade `getFacadeAcc