Remove if TYPE_CHECKING clause from most model files #342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why?
Motivation: Propagate types in schema.d.ts.
After a session with AI, I stumbled upon a solution that satisfies all three:
It is possible to add imports to the bottom of the file and avoid
if TYPE_CHECKINGclauses. This works because:It turns out we can likely remove all
if TYPE_CHECKINGclauses. This PR does it for all files except annotations (todo later).Two other changes were needed:
__init__.pyHow has it been tested?
CI
Did you update CHANGELOG.md?