Improve video frame streaming #335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/review |
ikondrat
reviewed
Dec 24, 2025
| self.close() | ||
|
|
||
|
|
||
| def _get_cached_capture(video_path: str) -> cv2.VideoCapture: |
Contributor
There was a problem hiding this comment.
I think we need tests for this
ikondrat
requested changes
Dec 24, 2025
Contributor
ikondrat
left a comment
ikondrat
left a comment
There was a problem hiding this comment.
lgtm but it is better to cover changes with tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why?
Updated the video frame streaming function:
compressedquery parameter to request JPEG (quality 60) instead of PNGHow has it been tested?
Tested locally with local and cloud videos.
You can use the following cloud videos to test:
"gs://lightly-edge-datasets/video_eval/Video6.mp4" - longer video with higher res frames
"gs://worker-test-datasets/50k_videos/protex_1/videos_100" - shorter videos
Example with cloud videos:
New implementation
https://github.com/user-attachments/assets/6cf2f95d-74fc-4602-9931-8aaa08f82037
Old implementation
https://github.com/user-attachments/assets/f755adaf-6b83-49da-903b-ac356b905d7d
Did you update CHANGELOG.md?