Skip to content

Add --output-filename to output generated objects to #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
terraboops wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add --output-filename to output generated objects to #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions cmd/audit2rbac/audit2rbac.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,33 @@ func NewAudit2RBACCommand(stdout, stderr io.Writer) *cobra.Command {

showVersion := false

outputFilename := ""

cmd := &cobra.Command{
Use: "audit2rbac --filename=audit.log [ --user=bob | --serviceaccount=my-namespace:my-sa ]",
Short: "",
Long: "",
Run: func(cmd *cobra.Command, args []string) {
var tmpFile *os.File
var err error

if showVersion {
fmt.Fprintln(stdout, "audit2rbac version "+pkg.Version)
return
}

if outputFilename != "" {

tmpFile, err = os.CreateTemp("", "audit2rbac")
if err != nil {
fmt.Fprintln(stderr, err)
fmt.Fprintln(stderr)
cmd.Help()
os.Exit(1)
}
options.Stdout = tmpFile
}

checkErr(stderr, options.Complete(serviceAccount, args, name, annotations, labels))

if err := options.Validate(); err != nil {
Expand All @@ -79,10 +96,12 @@ func NewAudit2RBACCommand(stdout, stderr io.Writer) *cobra.Command {
}

checkErr(stderr, options.Run())
checkErr(stderr, os.Rename(tmpFile.Name(), outputFilename))
},
}

cmd.Flags().StringArrayVarP(&options.AuditSources, "filename", "f", options.AuditSources, "File, URL, or - for STDIN to read audit events from")
cmd.Flags().StringVar(&outputFilename, "output-filename", name, "File to write output manifests to")

cmd.Flags().StringVar(&options.User, "user", options.User, "User to filter audit events to and generate role bindings for")
cmd.Flags().StringVar(&serviceAccount, "serviceaccount", serviceAccount, "Service account to filter audit events to and generate role bindings for, in format <namespace>:<name>")
Expand Down Expand Up @@ -292,23 +311,23 @@ func (a *Audit2RBACOptions) Run() error {
firstSeparator = false
return
}
fmt.Fprintln(os.Stdout, "---")
fmt.Fprintln(a.Stdout, "---")
}
for _, obj := range generated.Roles {
printSeparator()
pkg.Output(os.Stdout, obj, "yaml")
pkg.Output(a.Stdout, obj, "yaml")
}
for _, obj := range generated.ClusterRoles {
printSeparator()
pkg.Output(os.Stdout, obj, "yaml")
pkg.Output(a.Stdout, obj, "yaml")
}
for _, obj := range generated.RoleBindings {
printSeparator()
pkg.Output(os.Stdout, obj, "yaml")
pkg.Output(a.Stdout, obj, "yaml")
}
for _, obj := range generated.ClusterRoleBindings {
printSeparator()
pkg.Output(os.Stdout, obj, "yaml")
pkg.Output(a.Stdout, obj, "yaml")
}

fmt.Fprintln(a.Stderr, "Complete!")
Expand Down