Skip to content

Conversation

@Hayden2018
Copy link

@Hayden2018 Hayden2018 commented Sep 24, 2023

Currently collections are shown under the collections tab even if no routes are in the collection, making it looks like an layout bug. This commit hide the entire collection if there are no routes in that collection.
image

@chunlaw
Copy link
Member

chunlaw commented Sep 25, 2023

I have tried it. Would you like to add an image to instruct user how to add route to collection? Otherwise, it will be a blank page for new users, and they likely have no idea what's going on

@Hayden2018
Copy link
Author

Hayden2018 commented Sep 25, 2023

I think that make sense. For consistency sake all other tabs including "常用" or "Home" should show the same image when having no data? Maybe similar to the one in "車站" ?

@chunlaw
Copy link
Member

chunlaw commented Sep 25, 2023

Yes, go ahead. Suggested to prepare 4 images, each for one combination of language and color theme.

@Hayden2018
Copy link
Author

Sure. Will see what i can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants