feat: add arm64 support #291
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
One note here: the second commit removes the GOOS=linux GOARCH=amd64 as otherwise this won't work. |
Author
|
I put it on draft as this needs to be tested in this repo. |
Author
|
similar to #269 + fixed ENV in Dockerfile |
Author
|
@hibiken are you able to test this somehow? |
|
any update? |
|
Is this repo still maintained? This is a great change that would help a lot of ppl on macOS or arm64 servers |
Author
|
last commit 2 years ago, I suspect this is abandoned... |
Author
|
by now, 2 years later, there are even native runners available: https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds arm64 images to dockerhub
#292