chore(deps): update dotnet monorepo to v10 (major) #3072
Conversation
trusted-contributions-gcf
bot
added
the
kokoro:force-run
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant upgrade of several key .NET dependencies and the underlying .NET SDK. The primary goal is to bring the project up to date with the latest major versions of these components, ensuring compatibility with newer features, performance enhancements, and security updates provided by the updated frameworks and libraries. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several .NET dependencies to major new versions. However, most of the updated package versions are set to 10.0.0, which appears to be an invalid or non-existent version. This will likely cause the build to fail. I've recommended changing these versions to 8.0.0, which is the latest stable version and aligns with the .NET 8 target frameworks used in the solution. Additionally, the .NET SDK is being updated to a .NET 9 preview version. This is a significant change that should be carefully considered, especially in conjunction with the dependency versions.
| <PackageReference Include="Microsoft.Extensions.Configuration" Version="10.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="10.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.0" /> |
There was a problem hiding this comment.
These packages are being updated to version 10.0.0, which appears to be an unstable or non-existent pre-release version. This project targets .NET 8, so it's recommended to update these dependencies to the latest stable version compatible with .NET 8, which is 8.0.0. This will ensure stability and prevent potential build failures.
<PackageReference Include="Microsoft.Extensions.Configuration" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.0" />
|
|
||
| <ItemGroup Condition="'$(TargetFramework)'=='netstandard2.0'"> | ||
| <PackageReference Include="System.Management" Version="7.0.2" /> | ||
| <PackageReference Include="System.Management" Version="10.0.0" /> |
There was a problem hiding this comment.
The System.Management package is being updated to version 10.0.0, which is likely an unstable or non-existent pre-release. It's recommended to use the latest stable version, 8.0.0, to ensure stability and avoid potential build issues.
<PackageReference Include="System.Management" Version="8.0.0" />
|
|
||
| <ItemGroup Condition="'$(TargetFramework)'=='net6.0'"> | ||
| <PackageReference Include="System.Management" Version="7.0.2" /> | ||
| <PackageReference Include="System.Management" Version="10.0.0" /> |
There was a problem hiding this comment.
Similar to the netstandard2.0 target, the System.Management package for net6.0 is being updated to version 10.0.0. This is likely an unstable or non-existent pre-release. It's recommended to use the latest stable version, 8.0.0, to ensure stability.
<PackageReference Include="System.Management" Version="8.0.0" />
| <PackageReference Include="Microsoft.Extensions.Hosting" Version="10.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="10.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Http" Version="10.0.0" /> |
There was a problem hiding this comment.
These packages are being updated to version 10.0.0, which appears to be an unstable or non-existent pre-release version. Since this project targets .NET 8, it's recommended to update these dependencies to the latest stable version compatible with .NET 8, which is 8.0.0. This will ensure stability and prevent potential build failures.
<PackageReference Include="Microsoft.Extensions.Hosting" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Http" Version="8.0.0" />
|
@amanda-tarafa: I'm assuming we don't want to do this? Will leave you to close it in case you think we should take these changes (or some subset of them). |
renovate-bot
force-pushed
the
renovate/major-dotnet-monorepo
branch
from
32f115f to
836af3c
Compare
renovate-bot
changed the title
amanda-tarafa
added
the
do not merge
|
Keeping around until we've chatted. |
renovate-bot
force-pushed
the
renovate/major-dotnet-monorepo
branch
from
836af3c to
0a63932
Compare
renovate-bot
force-pushed
the
renovate/major-dotnet-monorepo
branch
from
0a63932 to
6cb9dfa
Compare
renovate-bot
force-pushed
the
renovate/major-dotnet-monorepo
branch
from
6cb9dfa to
049601f
Compare
3 participants
This PR contains the following updates:
6.0.2->10.0.16.0.1->10.0.16.0.1->10.0.16.0.1->10.0.16.0.1->10.0.16.0.1->10.0.17.0.2->10.0.18.0.416->10.0.101Release Notes
dotnet/dotnet (Microsoft.Extensions.Configuration)
v10.0.1v9.0.7: .NET 9.0.7You can build .NET 9.0 from the repository by cloning the release tag
v9.0.7and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.6: .NET 9.0.6You can build .NET 9.0 from the repository by cloning the release tag
v9.0.6and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.5: .NET 9.0.5You can build .NET 9.0 from the repository by cloning the release tag
v9.0.5and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.4: .NET 9.0.4You can build .NET 9.0 from the repository by cloning the release tag
v9.0.4and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.3: .NET 9.0.3You can build .NET 9.0 from the repository by cloning the release tag
v9.0.3and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.2: .NET 9.0.2You can build .NET 9.0 from the repository by cloning the release tag
v9.0.2and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.1: .NET 9.0.1You can build .NET 9.0 from the repository by cloning the release tag
v9.0.1and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.0: .NET 9.0.0You can build .NET 9.0 from the repository by cloning the release tag
v9.0.0and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.0: .NET 8.0You can build .NET 8.0 from the repository by cloning the release tag
v8.0.0and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dotnet.microsoft.com/download/dotnet/release-key-2023.asc
dotnet/sdk (dotnet-sdk)
v10.0.101: .NET 10.0.1Compare Source
Release
What's Changed
vs2022Image rejecting preview sdks, failing to resolve sdks by @nagilson in #51558vs2022Image rejecting preview sdks, failing to resolve sdks by @github-actions[bot] in #51621Full Changelog: dotnet/sdk@v10.0.100...v10.0.101
v10.0.100: .NET 10.0.0Compare Source
Release
What's Changed
unsetby @github-actions[bot] in #509632801306by @dotnet-bot in #509742802347by @dotnet-bot in #51014dnx --helpand tool commands to use valid .NET tool examples by @github-actions[bot] in #510422804587by @dotnet-bot in #510312810403by @dotnet-bot in #51160.slnxto default.editorconfigtemplate by @github-actions[bot] in #510952812555by @dotnet-bot in #511882813133by @dotnet-bot in #51195Full Changelog: dotnet/sdk@v10.0.100-rc.2.25502.107...v10.0.100
v9.0.308Compare Source
v9.0.307: .NET 9.0.11Compare Source
Release
What's Changed
Configuration
📅 Schedule: Branch creation - "before 8am every weekday" in timezone Europe/London, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.