Fix: Prevent overriding child view presentation detents #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When NavigationStackFlow is initialized without the 'detents' parameter, it was applying .presentationDetents([]) (empty set) which incorrectly overrode presentation detents defined in child views. This change introduces OptionalPresentationDetentsModifier that only applies presentation detents when they are explicitly provided (non-nil), allowing child views to define their own detents without interference. Issue: - Child views using .presentationDetents() were being overridden - Sheets would open at maximum detent instead of specified heights - Close buttons and custom detent behaviors were broken Solution: - Replace .presentationDetents(navigationDetents ?? []) with conditional modifier - Only apply detents when explicitly provided via init parameter - Preserve backward compatibility for existing code
jmarek41
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NavigationStackFlow is initialized without the 'detents' parameter, it was applying .presentationDetents([]) (empty set) which incorrectly overrode presentation detents defined in child views.
This change introduces OptionalPresentationDetentsModifier that only applies presentation detents when they are explicitly provided (non-nil), allowing child views to define their own detents without interference.
Issue:
Solution: