Add support of Height detents and animation #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of PresentationDetent.height for NavigationStack displayed as modal sheet cover.
This approach will recalculate height of currently presented view which is part of NavigationStack in modal sheet cover.
Issue: When navigating from higher view to lower one the presentation detents is set correctly but the content of that particular scene has a weird animation. @jmarek41 @samoilyk @mikolasstuchlik do you have any idea how to get rid of that unwanted animation ? 🤔 (The issue is visible in last part of the video starting from 16s)
Other PresentationDetents (.large, .medium, .fraction) works without any issue and it's already merged to main so it can be part of a new version of FuturedKit w/o support of PresentationDetent.height. The code for those presentation detents is more simple (see PR).
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-06.at.20.31.42.mp4