Fix iOS KMP working directory #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The beta.sh and test.sh scripts were running bundle install before changing to the CUSTOM_BUILD_PATH directory. This caused them to install gems from the wrong Gemfile (root directory instead of the iOS directory). Now the scripts: 1. Change to CUSTOM_BUILD_PATH first (if specified) 2. Install bundler 3. Run bundle install (which now uses the correct Gemfile) 4. Run fastlane commands This ensures fastlane and other iOS-specific gems are installed from the correct Gemfile location. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…tructures This change supports iOS projects with multiple apps under a single iosApp directory, where the Gemfile is at the root (iosApp/) but Fastfiles are in subdirectories (e.g., iosApp/appA/, iosApp/appB/). Changes: - Added ios_root_path input: Path to iOS project root with Gemfile - custom_build_path now means: Path to directory with Fastfile - Scripts install gems from ios_root_path, run fastlane from custom_build_path - Updated ios-kmp-build to always use iosApp as ios_root_path Use cases supported: 1. Single app in iosApp: only set custom_build_path=iosApp 2. Multiple apps: ios_root_path=iosApp, custom_build_path=iosApp/appA 3. Backwards compatible: only custom_build_path works as before 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Update the input description to reflect the new behavior where custom_build_path expects the full path to the Fastfile directory (e.g., iosApp/appA) rather than a relative path. This aligns with the changes made to ios-kmp-build action. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…-release Apply the same path separation pattern to ios-fastlane-release action that was implemented for beta and test actions. This ensures consistent behavior across all iOS fastlane actions and supports multi-app iOS project structures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace inline fastlane commands with ios-fastlane-test and ios-fastlane-release composite actions for consistency and maintainability. Benefits: - Consistent behavior across all workflows - Single source of truth for fastlane execution - Easier to maintain and update - Supports future path customization if needed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
jmarek41
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
ios_root_pathandcustom_build_pathinputs to the iOS Fastlane actions.These inputs provide greater flexibility in specifying the working directories for
bundle installandfastlaneexecution.The KMP workflows are updated to utilize these new parameters.
Key Features
ios_root_pathinput: Allows specifying the path to the iOS project root directory containing theGemfileforbundle install.custom_build_pathinput: Allows specifying the path to the directory containing theFastfileforfastlaneexecution.ios-kmp-selfhosted-releaseandios-kmp-selfhosted-testworkflows now use the new `ios-fast