Skip to content

Conversation

@ssestak
Copy link
Contributor

@ssestak ssestak commented Nov 5, 2025

Correct working-directory usage and custom_build_path in ios-kmp-build action.

This PR addresses an invalid working-directory usage with a uses step.
It also refines the custom_build_path logic for the Fastlane Beta action.

Key Changes:

  • Removed working-directory: iosApp from the Fastlane Beta step in .github/actions/ios-kmp-build/action.yml.
  • Modified the custom_build_path input for the Fastlane Beta step to correctly handle path construction.

custom_build_path Logic Update:

Old Value New Value
${{ inputs.ios_custom_build_path }} ${{ inputs.ios_custom_build_path && format('iosApp/{0}', inputs.ios_custom_build_path) || 'iosApp' }}

The working-directory property is only valid for run steps (shell commands),
not for steps that use 'uses' to call other actions. This was causing GitHub
Actions to fail with "Unexpected value 'uses'" and "Required property is missing: run".

The fix properly handles the iosApp directory by prepending it to the custom_build_path
parameter, ensuring the ios-fastlane-beta action receives the correct full path.

- If ios_custom_build_path is provided: Uses 'iosApp/{custom_path}'
- If not provided: Uses 'iosApp' as default
@ssestak ssestak requested a review from matejsemancik November 5, 2025 08:53
@matejsemancik matejsemancik merged commit d390d82 into main Nov 5, 2025
1 check passed
@matejsemancik matejsemancik deleted the fix/ios-kmp-build-working-directory branch November 5, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants