-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor iOS workflows #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rkflows Automates Fastlane operations for iOS applications, streamlining CI/CD processes. Also adds *.DS_Store to .gitignore.
…icated Fastlane action Refactored the Fastlane Beta step into a reusable composite action, removed redundant inputs, and added explicit changelog and timeout inputs for improved flexibility and clarity.
…nd add Danger token Refactor the Fastlane test step to use the `ios-fastlane-test` reusable action for improved maintainability. Introduce a dedicated `GITHUB_TOKEN_DANGER` secret for Danger integration and add a configurable `timeout_minutes` input.
Extracts the Fastlane release logic into a reusable GitHub Action for improved modularity and maintainability. Also introduces a configurable 'timeout_minutes' input for the job.
This workflow automates the nightly build process for iOS applications using self-hosted GitHub Actions runners, including changelog generation, secret export, Fastlane Beta deployment, and artifact uploads.
…reference Conditionally skips build-related steps based on change detection output and updates the 'ios-fastlane-beta' action to use a centralized reference.
Fastlane scripts in iOS beta, release, and test actions were not receiving necessary input parameters, leading to failures or incorrect behavior.
…ta step Replaced inline shell commands with a dedicated GitHub Action to improve maintainability and reusability.
This commit temporarily updates the iOS workflows to use the 'feature/refactor-iOS-workflows' branch for Fastlane actions. This change must be reverted before merging into the main branch.
The working directory for these actions is now configured at the workflow level, making the explicit `cd iosApp` command unnecessary and potentially problematic.
This reverts commit 63d258a.
…hens Standardize workflow file naming convention.
1a2da70 to
9b955c1
Compare
…lfhosted-on-demand-build.yml Moved the original build logic from `ios-selfhosted-build.yml` to `ios-selfhosted-on-demand-build.yml` to distinguish on-demand builds. The `ios-selfhosted-build.yml` now calls `ios-selfhosted-nightly-build.yml`.
Update README to reflect the deprecation of `ios-selfhosted-build` in favor of `ios-selfhosted-nightly-build` and `ios-selfhosted-on-demand-build`.
Ensures robustness of shell commands by properly quoting the output file path.
4fbbf46 to
b962669
Compare
This workflow is deprecated and users should migrate to ios-selfhosted-nightly-build.yml.
| bundle install --jobs 4 --retry 3 | ||
| bundle exec fastlane test | ||
| env: | ||
| DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know how this token was provided before ? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jmarek41
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Environment variables are now directly set in `action.yml`, eliminating the need for explicit re-exporting in the associated shell scripts.
The github_token and GITHUB_TOKEN_DANGER inputs are no longer strictly required for iOS Fastlane test actions and self-hosted test workflows, allowing for more flexible execution.
Fastlane expects `PR_TITLE` environment variable for the changelog when building beta versions.
…workflows # Conflicts: # .github/actions/ios-kmp-build/action.yml


This PR modularizes iOS Fastlane operations into reusable GitHub Actions and refactors existing workflows to leverage them. It introduces new dedicated workflows for nightly and on-demand iOS builds, enhancing CI/CD structure.
Key Features:
ios-fastlane-beta: Standardizes Fastlane beta execution.ios-fastlane-release: Standardizes Fastlane release execution.ios-fastlane-test: Standardizes Fastlane test execution.ios-kmp-build.yml: Updated to use the newios-fastlane-betaaction.ios-selfhosted-release.yml: Updated to use the newios-fastlane-releaseaction.ios-selfhosted-test.yml: Updated to use the newios-fastlane-testaction andGITHUB_TOKEN_DANGER.ios-selfhosted-nightly-build.yml: Implements a new workflow for nightly iOS builds with change detection and artifact uploads.ios-selfhosted-on-demand-build.yml: Provides a new workflow for manual, on-demand iOS builds with changelog input.ios-selfhosted-build.ymlis now deprecated and callsios-selfhosted-nightly-build.yml.*.DS_Storeto.gitignore.Workflow Changes Overview:
ios-selfhosted-build.yml)ios-selfhosted-build.yml)ios-selfhosted-nightly-build.yml