Skip to content

Conversation

@manusa
Copy link
Member

@manusa manusa commented Dec 18, 2025

Description

Related to #7371 #7386 #7376

The root-cause of the issue is the fact that the type processing in

for _, pkg := range context.Universe {
for _, t := range pkg.Types {
for memberIndex, member := range t.Members {
for _, memberProcessor := range g.memberProcessors {
memberProcessor(context, pkg, t, &member, memberIndex)
}
}
}
for _, packageProcessor := range g.packageProcessors {
packageProcessor(context, pkg)
}
}

doesn't follow a deterministic order.

Since the processInlineDuplicateFields processes the child embedded type members, it might be the case that one of these members hasn't been processed by the processSwaggerIgnore processor yet.

After multiple iterations trying to find a simpler+granular solution, I couldn't come up with the granular one that preserved simplicity.
Keeping things granular and focused (i.e. not considering the swaggerignore tags in the inlineduplicatefields processor) requires adding too much complexity to the code which in the ends defeats the simplicity purpose.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa marked this pull request as draft December 18, 2025 16:00
@manusa manusa marked this pull request as ready for review December 18, 2025 16:22
@ash-thakur-rh ash-thakur-rh self-requested a review December 18, 2025 16:44
@ash-thakur-rh ash-thakur-rh self-requested a review December 18, 2025 16:45
Copy link
Contributor

@ash-thakur-rh ash-thakur-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Strange issue BTW 😅

@manusa manusa added this to the 7.5.0 milestone Dec 19, 2025 — with automated-tasks
@manusa manusa merged commit 366fe51 into fabric8io:main Dec 19, 2025
18 of 19 checks passed
@manusa manusa deleted the openapi/embedded branch December 19, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants