Skip to content

Conversation

@angelikatyborska
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps
    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

Automated comment created by PR Commenter 🤖.

@angelikatyborska
Copy link
Member Author

I believe the dialyzer errors are caused by elixir-lang/elixir#14837

@angelikatyborska
Copy link
Member Author

This one as well: jeremyjh/dialyxir#563 but it was created before Elixir 1.19.0 was released 🤔 unless somebody tested on a rc version.

@angelikatyborska
Copy link
Member Author

@jiegillet Did you encounter this error at work maybe? I have no idea what to do.

@neenjaw
Copy link
Contributor

neenjaw commented Nov 5, 2025

is it possible it is using an old plt that is incompatible with the new version?

@angelikatyborska
Copy link
Member Author

The cache key on Github CI includes the exact Elixir version and file has of mix.lock, so unlikely. I also tested locally by deleting plts first, same results 😞

@dabaer
Copy link
Contributor

dabaer commented Nov 6, 2025

I've also encountered the dialyxer issue at work, unfortunately no amount of build and plt cleaning or config tweaking resolves the errors.

Hopefully it's fixed soon upstream

@angelikatyborska angelikatyborska marked this pull request as ready for review November 7, 2025 08:38
@angelikatyborska
Copy link
Member Author

angelikatyborska commented Nov 7, 2025

It worked! 🎉 It required upgrading dialyxir to 1.4.7 and Elixir to 1.19.2, as well as adding a flags: [:no_opaque] flag to the dialyzer config (as suggested in elixir-lang/elixir#14837 (comment))

This PR could be approved and merged right now, but I'm still waiting on an official 1.19.2 Docker image for the tooling repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants