OPS-1069: Add worker differentiation, and change setting defaults #83
Conversation
| - name: FIDES__REDIS__SSL_CERT_REQS # Accepted values include: none, optional and require. | ||
| value: "none" | ||
| - name: FIDES__EXECUTION__USE_DSR_3_0 | ||
| value: "true" |
There was a problem hiding this comment.
This is now deprecated (it only uses DSR 3.0) as of 2.70.0. That being said, it's not wrong to add it, but it will only take effect for those on <2.70.0.
| Detect if fidesplus is being used based on the repository name | ||
| */}} | ||
| {{- define "fides.isFidesplus" -}} | ||
| {{- if contains "fidesplus" (.Values.fides.image.repository | lower) -}} |
There was a problem hiding this comment.
This is a good idea, but if anyone is re-building the docker file to host on an internal image repo (e.g. ECR), it won't necessarily have fidesplus in the name.
It might make more sense to have an explicit variable? Then we could use that explicit variable to automatically set the default docker repo?
There was a problem hiding this comment.
Hmm, good catch. Can I have an override instead?
There was a problem hiding this comment.
You said this wouldn't be a problem for custom docker repos, right?
There was a problem hiding this comment.
I can go test. Give me a bit please.
There was a problem hiding this comment.
Looks good, ready to merge I think.
github-actions
bot
added
the
documentation
RobertKeyser
left a comment
RobertKeyser
left a comment
There was a problem hiding this comment.
LGTM. Feel free to merge when you're ready
I added worker differentiation, and changed some of the setting defaults as requested by @tvandort .
This PR refactors the worker configuration, replacing the single worker pool with the ability to define multiple specialized worker deployments. I also added logic to auto-configure these specialized workers for Fidesplus deployments and updated some default settings, some of them might need to be changed later on though, like DSR 3.
Pre-merge Checklist