Skip to content

Update docs links and add CA conditional #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvandort merged 4 commits into from
Aug 15, 2025
Merged

Update docs links and add CA conditional #82

tvandort merged 4 commits into from
Aug 15, 2025

Conversation

@tina-zimnicki
Copy link
Contributor

@tina-zimnicki tina-zimnicki commented Aug 14, 2025 •
edited
Loading

Description of Changes

  • Changes the way CA secrets are handled, to no longer require them if user decides to use Redis without TLS
  • Updates docs link in values.yaml

Pre-merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Increment Applicable Chart Versions
  • Relevant Follow-Up Issues Created
  • Update the Fides chart CHANGELOG.md
  • Update the Fides-minimal chart CHANGELOG.md

@tina-zimnicki tina-zimnicki requested a review from a team as a code owner August 14, 2025 23:15
tvandort
tvandort approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@tvandort tvandort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

RobertKeyser
RobertKeyser reviewed Aug 15, 2025
View reviewed changes
@RobertKeyser
Copy link
Contributor

RobertKeyser commented Aug 15, 2025

Everything looks good, but make sure to update the CHANGELOG.md (only for fides, not fides-minimal)

RobertKeyser
RobertKeyser approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@RobertKeyser RobertKeyser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you so much for taking this on

@tvandort tvandort merged commit c2799ce into ethyca:main Aug 15, 2025
2 of 3 checks passed
@tina-zimnicki tina-zimnicki deleted the minor-values-fixes branch August 15, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvandort tvandort tvandort approved these changes

@RobertKeyser RobertKeyser RobertKeyser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tina-zimnicki @RobertKeyser @tvandort