Skip to content

Conversation

@horw
Copy link
Collaborator

@horw horw commented Jan 7, 2025

Description

Updated the test and added BoolStmt to all.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@github-actions
Copy link

github-actions bot commented Jan 7, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
esp_bool_parser
   bool_parser.py1231885%49, 74, 77, 80, 92–106, 164, 169, 177, 181
   constants.py411368%19–20, 45–57
   soc_header.py684140%54–64, 77–82, 86–93, 97–138
   utils.py24292%76–77
TOTAL2627472% 

Tests Skipped Failures Errors Time
52 1 💤 0 ❌ 0 🔥 0.664s ⏱️

@horw horw requested a review from hfudev January 7, 2025 09:01
@hfudev
Copy link
Member

hfudev commented Jan 7, 2025

LGTM. Shall we export SUPPORTED_TARGETS, PREVIEW_TARGETS, ALL_TARGETS, IDF_VERSION_MAJOR, IDF_VERSION_MINOR, ...

as well?

@horw
Copy link
Collaborator Author

horw commented Jan 7, 2025

@hfudev Thank you! This solution in pytest-embedded with lazy loading is nice.

@hfudev hfudev merged commit 6a0a17d into main Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants