Skip to content

9p: add preflight check for 9p hvsock #5067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
redbeam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

9p: add preflight check for 9p hvsock #5067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions pkg/crc/preflight/preflight_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,20 +177,31 @@ func username() string {

const (
// This key is required to activate the vsock communication
registryDirectory = `HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Virtualization\GuestCommunicationServices`
vsockRegistryDirectory = `HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Virtualization\GuestCommunicationServices`
// First part of the key is the vsock port. The rest is not used and just a placeholder.
registryKey = "00000400-FACB-11E6-BD58-64006A7986D3"
registryValue = "gvisor-tap-vsock"
gvisorVsockRegistryKey = "00000400-FACB-11E6-BD58-64006A7986D3"
gvisorVsockRegistryValue = "gvisor-tap-vsock"
fs9pVsockRegistryKey = "00009000-FACB-11E6-BD58-64006A7986D3"
fs9pVsockRegistryValue = "fs9p-hvsock"
)

func checkVsock() error {
stdout, _, err := powershell.Execute(fmt.Sprintf(`Get-Item -Path "%s\%s"`, registryDirectory, registryKey))
stdout, _, err := powershell.Execute(fmt.Sprintf(`Get-Item -Path "%s\%s"`, vsockRegistryDirectory, gvisorVsockRegistryKey))
if err != nil {
return err
}
if !strings.Contains(stdout, registryValue) {
return errors.New("VSock registry key not correctly configured")
if !strings.Contains(stdout, gvisorVsockRegistryValue) {
return errors.New("VSock registry key for gvisor not correctly configured")
}

stdout, _, err = powershell.Execute(fmt.Sprintf(`Get-Item -Path "%s\%s"`, vsockRegistryDirectory, fs9pVsockRegistryKey))
if err != nil {
return err
}
if !strings.Contains(stdout, fs9pVsockRegistryValue) {
return errors.New("VSock registry key for 9P not correctly configured")
}

return nil
}

Expand Down
Loading