Skip to content

Conversation

@reyhankoyun
Copy link
Contributor

@reyhankoyun reyhankoyun commented Dec 10, 2025

Issue #, if available:

Description of changes:
This PR builds off of PR #122 and creates a benchmark workflow similar to integration tests workflow that runs the benchmarks added in PR #122

Add two basic benchmarks

  • One that performs cache hit retrievals
  • One that intentionally yields cache misses on every retrieval

Using criterion (used by the AWS SDK for Rust).

This hopefully will serve to catch performance regressions in future code changes and open the door to profiling.

Successful run from fork: https://github.com/reyhankoyun/aws-secretsmanager-agent/actions/runs/20082405961/job/57612354790

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@reyhankoyun reyhankoyun requested a review from a team as a code owner December 10, 2025 00:24
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 10, 2025
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 10, 2025
@reyhankoyun reyhankoyun changed the title Fix YAML indentation in benchmarks workflow Add benchmark workflow Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.88%. Comparing base (8554c56) to head (f1a3752).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files          14       14           
  Lines        2404     2404           
  Branches     2404     2404           
=======================================
  Hits         2209     2209           
  Misses        147      147           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 16, 2025
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 16, 2025
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 16, 2025
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 16, 2025
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 16, 2025
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 16, 2025
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 16, 2025
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 16, 2025
simonmarty
simonmarty previously approved these changes Dec 17, 2025
Signed-off-by: Simon Marty <[email protected]>
@simonmarty simonmarty added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 17, 2025
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 17, 2025
Copy link
Contributor

@simonmarty simonmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the upload is not succeeding with

Warning: No files were found with the provided path: aws_secretsmanager_caching/target/criterion/. No artifacts will be uploaded.

@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 18, 2025
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 18, 2025
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 18, 2025
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants